Use PHP 5.2 compatible constructor signature in custom Exception classes
Components
Labels
None
Description
Context Information
None
Additional information
None
Attachments
1
Activity
Show:
Alex July 25, 2012 at 10:29 AM
Since 5.2.0 version was released.
Alex June 19, 2012 at 8:55 AM
Fix committed to [b]5.2.x branch/b. Commit Message:
Fixes #0001327: Denying e-mail event produces fatal error (only on PHP < 5.3.0)
Alex June 19, 2012 at 8:55 AM
Will test all together later.
Fixed
Pinned fields
Click on the next to a field label to start pinning.
Details
Priority
Minor
Assignee
Reporter
Alex
AlexDeveloper
Alex
AlexChange Log Message
Fixes fatal error on e-mail event denial (on PHP 5.2.x)
Patch Instructions
Patches must be submitted through Phabricator.
To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial.
To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial.
External issue ID
1327
External issue URL
Story Points
1
Fix versions
Affects versions
Created June 19, 2012 at 8:53 AM
Updated December 29, 2024 at 9:04 PM
Resolved July 25, 2012 at 10:29 AM
In In-Portal 5.1.2 we've introduced e-mail event syntax check before saving (see #0000822) to prevent user from getting Fatal Error due incorrect template syntax when e-mail event will be sent.
However if you'll have a project were e-mail email events have template syntax errors in them and you upgrade this project to 5.1.2 then you still get Fatal Error, when trying to send out that e-mail event (because no automatic way to fix e-mails events, that are broken).
Also when trying to enable/disable these e-mail events from e-mail event list you'll get "Query method undefined" error and selected e-mail events will still be in same status as before.
Template syntax checking code was reworked in 5.2.0-RC1 to use PHP exceptions ([url]http://lv.php.net/manual/en/language.exceptions.php/url), but by mistake this code was made PHP 5.3.0+ compatible only (see [url]http://lv.php.net/manual/en/exception.construct.php/url) due $previous parameter usage, that was added only in PHP 5.3.0.