Uploaded image for project: 'In-Portal CMS'
  1. In-Portal CMS
  2. INP-1162

Add login/logout flag to url after successful login/logout

    XMLWordPrintable

    Details

    • Type: Bug Report
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.1.1
    • Fix Version/s: 5.2.1-B1
    • Component/s: Front End
    • Labels:
      None
    • Additional information:
      Hide

      Also content language negotiation redirect might not pass login state (login/logout parameter) to url where it redirects user.

      Show
      Also content language negotiation redirect might not pass login state (login/logout parameter) to url where it redirects user.
    • Change Log Message:
      Fixes page reload problem after login on Chrome
    • Story Points:
      1
    • External issue ID:
      1406
    • Copy Issue Key:
    • Patch Instructions:

      Patches must be submitted through Phabricator.

      Description

      There is a SEO rule, where 1 page content must have exactly 1 (and not more) url to it. If page content changes you:

      • either must send proper caching headers (which In-Portal doesn't do at all)
      • or change page url

      But if we show user-specific content (content that is one for logged-in users and other for non logged-in users) on a page, then, because we have same url to that page, browser can agressively cache it resulting after logout user being presented with logged-in only page version.

      This wasn't a problem before, but now once Google Chrome v21 (with MacBook Pro Retina support) is out it actually used it. I saw this on Vista (not Windows 7):

      1. visit website (you're not logged in)
      2. see "please login" sidebox on the left (while on home page)
      3. login
      4. browse through website
      5. press logout link
      6. see logged-in side box on the left instead of "please login" side box

      Despite long story problem is quite easy to fix:

      • add "?login=1 parameter to page url where user is redirected after login
      • add "?logout=1 parameter to page url where user is redirected after logout

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                alex Alex
                Reporter:
                alex Alex
                Developer:
                Alex
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: