Uploaded image for project: 'In-Portal CMS'
  1. In-Portal CMS
  2. INP-1181

Don't use "core/" for template path resolution in "m_ModuleInclude" tag

    XMLWordPrintable

    Details

    • Type: Bug Report
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.1.0
    • Fix Version/s: 5.2.1-B1
    • Component/s: Template System
    • Labels:
      None
    • Additional information:
      Hide

      We might try to risk and actually remove "core/" from Modules table and see how it will work afterwards.

      Show
      We might try to risk and actually remove "core/" from Modules table and see how it will work afterwards.
    • Change Log Message:
      Fixes misleading path being used by ModuleInclude tag
    • Story Points:
      1
    • External issue ID:
      1429
    • Copy Issue Key:
    • Patch Instructions:

      Patches must be submitted through Phabricator.

      Description

      In-Portal has 2 tags, that allow to use same template multiple times on other different templates:

      • <inp2:m_Include - includes 1 given template
      • <inp2:m_ModuleInclude - includes given template from each module

      [b]There is a problem[/b] with m_ModuleInclude tag in Admin Console, where he uses "core/" prefix to include templates from core module (see attached image). This works of course (otherwise whole "Structure & Data" section would be dead), but when you need to replace template, that is included (e.g. "catalog_tab" from core module), then you need to write "core/" before replaced template name.

      What I've described might not be a bug, but because of "Sections" tab in "Structure & Data" page is loaded via ajax and is accessing "catalog_tab" (and not "core/catalog_tab", that was replaced) resulting page uses original non-replaced template.

      [b]Solution:[/b]
      Inside m_ModuleInclude tag when we have "core/" as module path, then strip it.

      This way template replacement will work.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                alex Alex
                Reporter:
                alex Alex
                Developer:
                Alex
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: