Uploaded image for project: 'In-Portal CMS'
  1. In-Portal CMS
  2. INP-1237

Remove trailing separators from toolbar

    XMLWordPrintable

    Details

    • Type: Bug Report
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2.1-B2
    • Component/s: Admin Interfaces
    • Labels:
      None
    • Change Log Group:
      Fixed
    • Change Log Message:
      Trailing separators in Admin Console toolbar (usually happen after toolbar buttons are removed from interface preset) were not removed automatically.
    • Story Points:
      1
    • Copy Issue Key:
    • Patch Instructions:

      Patches must be submitted through Phabricator.

      Description

      On of main components of UI of Admin Console are toolbars. Typical toolbar looks like one on image below.

      As you can see toolbar consists of these items:

      • buttons
      • separators

      Developer can hide a specific button (but not separator) with by:

      • restricting access to a specific permission (e.g. if user can't add new records, then he shouldn't see "Add" button either)
      • specifying button in site config as part of interface preset

      If either way we can't guess which buttons will be hidden for each user before user tries to open page with a toolbar on it. Since we don't control separator appearance this could lead to these problems:

      1. when "Export" button is hidden we see 2 subsequent separators
      2. when "View" button is hidden we see separator at the end of toolbar
      3. when "Add" and "Edit" and "Delete" buttons are hidden we see separator at the beginning of toolbar

      Subsequent separator removal is already solved, but other 2 problems aren't. Attached patch fixes that problem.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                alex Alex
                Reporter:
                alex Alex
                Developer:
                Alex
                Reviewer:
                Dmitry Andrejev [Intechnic]
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: