Uploaded image for project: 'In-Portal CMS'
  1. In-Portal CMS
  2. INP-1243

Refactor "kTempTablesHandler" class

    XMLWordPrintable

    Details

    • Change Log Group:
      Changed
    • Change Log Message:
      Complete rewrite of "kTempTablesHandler" class for it to manage temp table classes instead of having methods, that accept table name.
    • Story Points:
      2
    • Copy Issue Key:
    • Patch Instructions:

      Patches must be submitted through Phabricator.

    • BC Break Details:
      Hide

      Properties deleted:

      • "kTempTablesHandler::$AlreadyProcessed"
      • "kTempTablesHandler::$CopiedTables"
      • "kTempTablesHandler::$DroppedTables"
      • "kTempTablesHandler::$FKeysCache"
      • "kTempTablesHandler::$FinalRefs"
      • "kTempTablesHandler::$MasterIDs"
      • "kTempTablesHandler::$MasterTable"
      • "kTempTablesHandler::$TableIdCounter"
      • "kTempTablesHandler::$Tables"
      • "kTempTablesHandler::$WindowID"
      • "kTempTablesHandler::$savedIDs"

      Method scope reduced:

      • "kTempTablesHandler::_getSeparateConnection" (was "public", now "protected")

      Methods deleted:

      • "kTempTablesHandler::AddTables"
      • "kTempTablesHandler::CopySubTablesToLive"
      • "kTempTablesHandler::CreateTempTable"
      • "kTempTablesHandler::DoCopyLiveToTemp"
      • "kTempTablesHandler::DoCopyTempToOriginal"
      • "kTempTablesHandler::DropTempTable"
      • "kTempTablesHandler::GetForeignKeys"
      • "kTempTablesHandler::GetLiveName"
      • "kTempTablesHandler::GetMasterTempName"
      • "kTempTablesHandler::GetTempName"
      • "kTempTablesHandler::GetTempTablePrefix"
      • "kTempTablesHandler::IsTempTable"
      • "kTempTablesHandler::RaiseEvent"
      • "kTempTablesHandler::SearchTable"
      • "kTempTablesHandler::SetTables"
      • "kTempTablesHandler::UpdateChangeLogForeignKeys"
      • "kTempTablesHandler::UpdateForeignKeys"
      • "kTempTablesHandler::getMainIDs"
      • "kTempTablesHandler::saveID"

      Methods reborn:

      • "kTempTablesHandler::CheckSimultaniousEdit" into "kTempHandlerTopTable::checkSimultaneousEdit"

      Method Signature Changed:

      • "kTempTablesHandler::CancelEdit" (removed optional "$master" parameter, that wasn't used outside of class)
      • "kTempTablesHandler::DeleteItems" (removed optional "$master" and "$foreign_key" parameters, that wasn't used outside of class)
      Show
      Properties deleted: "kTempTablesHandler::$AlreadyProcessed" "kTempTablesHandler::$CopiedTables" "kTempTablesHandler::$DroppedTables" "kTempTablesHandler::$FKeysCache" "kTempTablesHandler::$FinalRefs" "kTempTablesHandler::$MasterIDs" "kTempTablesHandler::$MasterTable" "kTempTablesHandler::$TableIdCounter" "kTempTablesHandler::$Tables" "kTempTablesHandler::$WindowID" "kTempTablesHandler::$savedIDs" Method scope reduced: "kTempTablesHandler::_getSeparateConnection" (was "public", now "protected") Methods deleted: "kTempTablesHandler::AddTables" "kTempTablesHandler::CopySubTablesToLive" "kTempTablesHandler::CreateTempTable" "kTempTablesHandler::DoCopyLiveToTemp" "kTempTablesHandler::DoCopyTempToOriginal" "kTempTablesHandler::DropTempTable" "kTempTablesHandler::GetForeignKeys" "kTempTablesHandler::GetLiveName" "kTempTablesHandler::GetMasterTempName" "kTempTablesHandler::GetTempName" "kTempTablesHandler::GetTempTablePrefix" "kTempTablesHandler::IsTempTable" "kTempTablesHandler::RaiseEvent" "kTempTablesHandler::SearchTable" "kTempTablesHandler::SetTables" "kTempTablesHandler::UpdateChangeLogForeignKeys" "kTempTablesHandler::UpdateForeignKeys" "kTempTablesHandler::getMainIDs" "kTempTablesHandler::saveID" Methods reborn: "kTempTablesHandler::CheckSimultaniousEdit" into "kTempHandlerTopTable::checkSimultaneousEdit" Method Signature Changed: "kTempTablesHandler::CancelEdit" (removed optional "$master" parameter, that wasn't used outside of class) "kTempTablesHandler::DeleteItems" (removed optional "$master" and "$foreign_key" parameters, that wasn't used outside of class)

      Description

      Refactor kTempTablesHandler class to make easier to read and modify in future.

        Attachments

          Issue Links

          parent of

          Bug Report - A problem which impairs or prevents the functions of the product. INP-1280 Ensure presence of 'parent_event' parameter in majority kTempTablesHandler usages

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug Report - A problem which impairs or prevents the functions of the product. INP-1310 Fix multiple foreign key support in Temp Handler

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          relates to

          Refactoring - INP-1203 OOP unit config creation

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          mentioned in

          Page Loading...

          Wiki Page Loading...

          Wiki Page Loading...

            Activity

              People

              • Assignee:
                alex Alex
                Reporter:
                alex Alex
                Developer:
                Alex
                Reviewer:
                Dmitry Andrejev [Intechnic]
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: