Uploaded image for project: 'In-Portal CMS'
  1. In-Portal CMS
  2. INP-1293

Record & display Module for Scheduled Tasks

    XMLWordPrintable

    Details

    • Change Log Group:
      Added
    • Change Log Message:
      Show In-Portal Module for each displayed Scheduled Task.
    • Story Points:
      1
    • Copy Issue Key:
    • Patch Instructions:

      Patches must be submitted through Phabricator.

    • BC Break Details:
      Hide

      Changed method signatures:

      • kApplication::registerScheduledTask (added required "$module" parameter)
      • kEventManager::registerScheduledTask (added required "$module" parameter)
      • kScheduledTaskManager::add (added required "$module" parameter)

      Solution

      1. for "kApplication::registerScheduledTask", "kEventManager::registerScheduledTask" and "kScheduledTaskManager::add" modules:
        • move "$module" parameter to the end of method declaration
        • make it optional with "null" default value
      2. in the "kScheduledTaskManager::add", when "$module" parameter isn't specified, then calculate it like this:
        • $event = new kEvent($event_string);
        • $module = $event->getUnitConfig()->getModule();
      3. in the "kUnitConfig::_parseScheduledTasks" method don't specify module at all, since it will be auto-detected anyway
      Show
      Changed method signatures: kApplication::registerScheduledTask (added required "$module" parameter) kEventManager::registerScheduledTask (added required "$module" parameter) kScheduledTaskManager::add (added required "$module" parameter) Solution for "kApplication::registerScheduledTask", "kEventManager::registerScheduledTask" and "kScheduledTaskManager::add" modules: move "$module" parameter to the end of method declaration make it optional with "null" default value in the "kScheduledTaskManager::add", when "$module" parameter isn't specified, then calculate it like this: $event = new kEvent($event_string); $module = $event->getUnitConfig()->getModule(); in the "kUnitConfig::_parseScheduledTasks" method don't specify module at all, since it will be auto-detected anyway

      Description

      Record & display Module for Scheduled Tasks.

      Plan additions:
      During unit config scanning a module of each unit config is determined to decide if we should skip this unit or not based on user's license. You need to:

      1. pass that module to "registerScheduledTask" method (there several of them) call for it to reach kScheduledTaskManager class and be available in unit config cache
      2. in "scheduled-task:OnRefresh" event ensure, that new module is stored in database
      3. for add Module dropdown to grid/edit form
      4. display label (instead of dropdown) on editing form for system scheduled tasks (ones added through unit config scanning).

        Attachments

        1. module_for_scheduled_tasks_v2.patch
          10 kB
          Erik Snarski [Intechnic]
        2. module_for_scheduled_tasks_v3.patch
          12 kB
          Erik Snarski [Intechnic]
        3. module_for_scheduled_tasks_v4.patch
          11 kB
          Alex
        4. module_for_scheduled_tasks.patch
          8 kB
          Erik Snarski [Intechnic]

          Issue Links

          bc break fixed by

          Task - A task that needs to be done. INP-1676 [bc fix] Record & display Module for Scheduled Tasks

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Scheduled
          mentioned in

          Page Loading...

            Activity

              People

              • Assignee:
                alex Alex
                Reporter:
                alex Alex
                Developer:
                Erik Snarski [Intechnic]
                Reviewer:
                Alex
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: