Uploaded image for project: 'In-Portal CMS'
  1. In-Portal CMS
  2. INP-1301

Make cloned unit config available during Url Processing

    XMLWordPrintable

    Details

    • Change Log Group:
      Fixed
    • Change Log Message:
      Fixed Fatal Error, when adding image to a category.
    • Story Points:
      2
    • Copy Issue Key:
    • Patch Instructions:

      Patches must be submitted through Phabricator.

    • BC Break Details:
      Hide

      Properties renamed:

      • "kUnitConfigReader::$AfterConfigProcessed" into "kUnitConfigReader::afterConfigProcessed"
      • "kUnitConfigReader::$FinalStage" into "kUnitConfigReader::$finalStage"
      • "kUnitConfigReader::$StoreCache" into "kUnitConfigReader::$storeCache"
      • "kUnitConfigReader::$_moduleFolderRegExp" into "kUnitConfigReader::$moduleFolderRegExp"
      • "kUnitConfigReader::$_directorySeparator" into "kUnitConfigReader::$directorySeparator"
      • "kUnitConfigReader::$_skipFolders" into "kUnitConfigReader::$skipFolders"

      Properties deleted:

      • "kUnitConfigReader::$CacheExpired" (wasn't used anywhere)
      • "kUnitConfigReader::$ProcessAllConfigs" (had same value all the time)

      Property scrope reduced (was public, now protected):

      • "kUnitConfigReader::$configData"
      • "kUnitConfigReader::$configFiles"
      • "kUnitConfigReader::$prefixFiles"

      Methods deleted:

      • "kUnitConfigReader::iterateConfigs"

      Methods renamed:

      • "kUnitConfigReader::_sortRewriteListeners" into "kUnitConfigReader:: sortRewriteListeners"
      • "kUnitConfigReader::prefixRegistred" into "kUnitConfigReader::prefixRegistered" (typo fix)
      • "kUnitConfigReader::ParseConfigs" info "kUnitConfigReader::parseConfigs"

      Method Signature Changed:

      • "kUnitConfigReader::scanModules" (renamed "$folderPath" into "$folder_path" parameter)
      • "kUnitConfigReader::findConfigFiles" (renamed "$folderPath" into "$folder_path" parameter)

      Methods reborn:

      • "kUnitConfigReader::postProcessConfig" into "kUnitConfigCloner::extrude"
      • "kUnitConfigReader::processDynamicClones" into "kUnitConfigCloner::processDynamicallyAdded"

      Method scope reduced (was public, now protected):

      • "kUnitConfigReader::getConfigName"
      • "kUnitConfigReader::configAllowed"
      • "kUnitConfigReader::PreloadConfigFile"
      • "kUnitConfigReader::findConfigFiles"
      • "kUnitConfigReader::includeConfigFiles"
      • "kUnitConfigReader::retrieveCollections"

      Solution

      1. add "kUnitConfigReader::prefixRegistred" method, that will:
        • have "@deprecated" tag
        • have "@see kUnitConfigReader::prefixRegistered()" tag
        • trigger silenced deprecation notice and return result of calling "kUnitConfigReader::prefixRegistered" method
      Show
      Properties renamed: "kUnitConfigReader::$AfterConfigProcessed" into "kUnitConfigReader::afterConfigProcessed" "kUnitConfigReader::$FinalStage" into "kUnitConfigReader::$finalStage" "kUnitConfigReader::$StoreCache" into "kUnitConfigReader::$storeCache" "kUnitConfigReader::$_moduleFolderRegExp" into "kUnitConfigReader::$moduleFolderRegExp" "kUnitConfigReader::$_directorySeparator" into "kUnitConfigReader::$directorySeparator" "kUnitConfigReader::$_skipFolders" into "kUnitConfigReader::$skipFolders" Properties deleted: "kUnitConfigReader::$CacheExpired" (wasn't used anywhere) "kUnitConfigReader::$ProcessAllConfigs" (had same value all the time) Property scrope reduced (was public, now protected): "kUnitConfigReader::$configData" "kUnitConfigReader::$configFiles" "kUnitConfigReader::$prefixFiles" Methods deleted: "kUnitConfigReader::iterateConfigs" Methods renamed: "kUnitConfigReader::_sortRewriteListeners" into "kUnitConfigReader:: sortRewriteListeners" "kUnitConfigReader::prefixRegistred" into "kUnitConfigReader::prefixRegistered" (typo fix) "kUnitConfigReader::ParseConfigs" info "kUnitConfigReader::parseConfigs" Method Signature Changed: "kUnitConfigReader::scanModules" (renamed "$folderPath" into "$folder_path" parameter) "kUnitConfigReader::findConfigFiles" (renamed "$folderPath" into "$folder_path" parameter) Methods reborn: "kUnitConfigReader::postProcessConfig" into "kUnitConfigCloner::extrude" "kUnitConfigReader::processDynamicClones" into "kUnitConfigCloner::processDynamicallyAdded" Method scope reduced (was public, now protected): "kUnitConfigReader::getConfigName" "kUnitConfigReader::configAllowed" "kUnitConfigReader::PreloadConfigFile" "kUnitConfigReader::findConfigFiles" "kUnitConfigReader::includeConfigFiles" "kUnitConfigReader::retrieveCollections" Solution add "kUnitConfigReader::prefixRegistred" method, that will: have "@deprecated" tag have "@see kUnitConfigReader::prefixRegistered()" tag trigger silenced deprecation notice and return result of calling "kUnitConfigReader::prefixRegistered" method

      Description

      Cache information about cloned unit config (e.g. "c-img") to allow using it prior to calling OnAfterConfigRead event of main prefix (e.g. "c").

      This is exactly the case, when url is being processed and OnAfterConfigRead event wasn't yet called.

        Attachments

          Issue Links

          bc break fixed by

          Task - A task that needs to be done. INP-1673 [bc fix] Make cloned unit config available during Url Processing

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Scheduled
          child of

          Refactoring - INP-1203 OOP unit config creation

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          parent of

          Bug Report - A problem which impairs or prevents the functions of the product. INP-1423 Don't use cached unit config clones in the middle of application initialization

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          mentioned in

          Page Loading...

          Page Loading...

            Activity

              People

              • Assignee:
                alex Alex
                Reporter:
                alex Alex
                Developer:
                Alex
                Reviewer:
                Dmitry Andrejev [Intechnic]
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: