Uploaded image for project: 'In-Portal CMS'
  1. In-Portal CMS
  2. INP-1327

Simplify custom permission checking in Event Handler

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Needs Review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 5.2.2
    • Labels:
      None
    • Change Log Group:
      Changed
    • Change Log Message:
      The less code writing is required to to perform custom access permission check.
    • Story Points:
      1
    • Sprint:
      In-Portal's 2nd Sprint, In-Portal's 3rd Sprint, In-Portal's 4th Sprint
    • Copy Issue Key:
    • Patch Instructions:

      Patches must be submitted through Phabricator.

      Description

      Plan:

      1. in "kEventHandler::CheckPermission" method (including descendant classes) just return true/false instead of calling "kPermissionsHelper::finalizePermissionCheck" method
      2. in "kRequestManager::runEvent" method check if calling "kEventHandler::CheckPermission" resulted in false and if so run "kPermissionsHelper::finalizePermissionCheck" method to ensure, that all redirect parameters are set properly (e.g. next template, etc.)

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                alex Alex
                Reporter:
                alex Alex
                Developer:
                Erik Snarski [Intechnic]
                Reviewer:
                Alex
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 16h 25m
                  16h 25m