-
Type: Refactoring
-
Status: Resolved
-
Priority: Minor
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 5.3.0-B1
-
Component/s: Url Processing
-
Labels:
-
Change Log Group:Added
-
Change Log Message:Allow specifying domain to be used in "kApplication::BaseURL" method.
-
Story Points:1
-
Copy Issue Key:
-
Patch Instructions:
-
BC Break Details:
Analysis (BaseURL method usages):
- total: 51
- where at least 1st ($prefix) parameter was given: 13
- where 2nd($ssl) and/or 3rd ($add_port) parameter was given: 1
Plan:
- migrate domain url part (only, when entered) from "SSL_URL" system setting to new "SSLDomain" system setting - 0.5h
- migrate domain url part (only, when entered) from "AdminSSL_URL" system setting to new "AdminSSLDomain" system setting - 0.5h
- perform similar migration for all site domains - 1h
- places where BaseURL method was used without any parameters given are unaffected
- move out $prefix parameter value after BaseURL method call (keep in mind trailing /) - 1h
- move out SSL url detection code from BaseURL into kUrlManager - 1h
- replace all BaseURL method parameters with optional $domain parameter, that would replace the domain, that this method wants to use (e.g. from site domain)
- pass in generated ssl domain (when ssl is about to be used) as $domain parameter in kUrlManager class - 0.5h