-
Type: Refactoring
-
Status: Closed
-
Priority: Minor
-
Resolution: Fixed
-
Affects Version/s: 5.0.2
-
Fix Version/s: 5.2.0-B1
-
Component/s: Data Management
-
Labels:
-
External issue URL:
-
Change Log Group:Changed
-
Change Log Message:Renamed "kCurrencyRates" into "CurrencyRates" class.
-
Story Points:1
-
External issue ID:572
-
Copy Issue Key:
-
Patch Instructions:
-
BC Break Details:
All currency converter classes are located in same file, not in separate files as they should. Base currency converter class is named "kCurrencyRates" (starting with "k"), but it is not part of In-Portal distribution, and belongs to In-Commerce module, so "k" should be removed. Also this class is registered not in unit config, but in kApplication class directly.
At the end all classes from file "\in-commerce\units\currencies\currency_rates.php" should be moved to "\in-commerce\units\helpers" folder and named properly, because they are actually helpers.