Uploaded image for project: 'In-Portal CMS'
  1. In-Portal CMS
  2. INP-1650

Declare each currency converter class in it's own file

    XMLWordPrintable

    Details

    • Change Log Group:
      Changed
    • Change Log Message:
      Renamed "kCurrencyRates" into "CurrencyRates" class.
    • Story Points:
      1
    • External issue ID:
      572
    • Copy Issue Key:
    • Patch Instructions:

      Patches must be submitted through Phabricator.

    • BC Break Details:
      Hide

      Renamed classes:

      • "kCurrencyRates" into "CurrencyRates"
      • "kBankLVCurrencyRates" into "BankLVCurrencyRates"
      • "kECBCurrencyRates" into "ECBCurrencyRates"
      • "kFRNYCurrencyRates" into "FRNYCurrencyRates"
      Show
      Renamed classes: "kCurrencyRates" into "CurrencyRates" "kBankLVCurrencyRates" into "BankLVCurrencyRates" "kECBCurrencyRates" into "ECBCurrencyRates" "kFRNYCurrencyRates" into "FRNYCurrencyRates"

      Description

      All currency converter classes are located in same file, not in separate files as they should. Base currency converter class is named "kCurrencyRates" (starting with "k"), but it is not part of In-Portal distribution, and belongs to In-Commerce module, so "k" should be removed. Also this class is registered not in unit config, but in kApplication class directly.

      At the end all classes from file "\in-commerce\units\currencies\currency_rates.php" should be moved to "\in-commerce\units\helpers" folder and named properly, because they are actually helpers.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                alex Alex
                Reporter:
                dmitry Dmitry Andrejev [Intechnic]
                Developer:
                Erik Snarski [Intechnic]
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: