Uploaded image for project: 'In-Portal CMS'
  1. In-Portal CMS
  2. INP-1677

[bc fix] Unify BaseURL method logic for ssl and non-ssl urls

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Scheduled
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 5.3.0-B1
    • Fix Version/s: 5.3.0
    • Component/s: Url Processing
    • Labels:
      None
    • Change Log Group:
      Deprecated
    • Change Log Message:
      Deprecated "$prefix" passing in 1st parameter of "kApplication::BaseURL" method.
    • Story Points:
      1
    • Copy Issue Key:
    • Patch Instructions:

      Patches must be submitted through Phabricator.

      Description

      1. for "kApplication::BaseURL" when "$domain" parameter isn't empty, but doesn't contain dot (domain usually contain dot):
        • treat it as removed "$prefix" parameter
        • set "$domain" to empty string (default domain)
        • trigger a deprecation notice (the "kUtil::deprecatedParameter" method call)

        Attachments

          Issue Links

          fixes bc break of

          Refactoring - INP-1328 Unify BaseURL method logic for ssl and non-ssl urls

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

            Activity

              People

              • Assignee:
                alex Alex
                Reporter:
                alex Alex
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: