[INP-1770] Load default user persistent settings all at once - In-Portal Issue Tracker

XML

Word

Printable

Change Log Group:
Changed
Change Log Message:
Removed unnecessary database queries for persistent session data loading.
Story Points:
1
Copy Issue Key:
Patch Instructions:
Patches must be submitted through Phabricator.
- To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial
- To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial

add protected "\SessionStorage::$defaultPersistentVars" property of "array" type
in the "\SessionStorage::LoadPersistentVars" method:
- get "DefaultSettingsUserId" system setting value with fallback to "USER_ROOT" constant value
- if default user isn't the same as current user, then store persistent settings of above retrieved user in the "\SessionStorage::$defaultPersistentVars" property
in the "\SessionStorage::RecallPersistentVar" method, when handling "$default == ALLOW_DEFAULT_SETTINGS" logic branch:
- if "$var_name" key exists in "\SessionStorage::$defaultPersistentVars" array, then store it's value under current user using "\SessionStorage::StorePersistentVar" call
- otherwise set "false" into "$this->PersistentVars[$var_name]" and "return false"
confirm, that these cases work & no more, than 2 SELECT happens from "UserPersistentSessionData" table:
- non-root user has a persistent setting
- non-root user doesn't have a persistent setting
- root user has a persistent setting
- root user doesn't have a persistent setting

implemented in

[Diffusion] rINP16654 Fixes INP-1770 - Load default user persistent settings all at once

D367 INP-1770 Load default user persistent settings all at once

Estimated:

Not Specified

Remaining:

Logged:

2h 44m