[INP-848] Misplaced field format validation code - In-Portal Issue Tracker

XML

Word

Printable

External issue URL:
http://tracker.in-portal.org/view.php?id=1047
Additional information:

Hide

This "regexp" option is specified in unit config file, like "core/units/users/users_config.php" in "Fields" array, e.g.

'Fields' => Array (
'Login' => Array ('type' => 'string', 'formatter' => 'kFormatter', 'regexp' => '/^user.*$/', 'default' => ''),
),

This will force all new users to have "user" in front of their login name to be entered before registration could continue.

Show
This "regexp" option is specified in unit config file, like "core/units/users/users_config.php" in "Fields" array, e.g. 'Fields' => Array ( 'Login' => Array ('type' => 'string', 'formatter' => 'kFormatter', 'regexp' => '/^user.*$/', 'default' => ''), ), This will force all new users to have "user" in front of their login name to be entered before registration could continue.
Change Log Message:
Moved "regexp" field option processing to kDBItem class
External issue ID:
1047
Copy Issue Key:
Patch Instructions:
Patches must be submitted through Phabricator.
- To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial
- To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial

In-Portal has ability to validate value in the field using given regular expression (regexp option in field definition).

All works fine, unless you need to change field value (not on form, but in code) before validation takes place.

To solve that problem I'm proposing to move processing of "regexp" option from kFormatter class into kDBItem class.