[INP-905] Sorting setting storage improvement ideas - In-Portal Issue Tracker

XML

Word

Printable

External issue URL:
http://tracker.in-portal.org/view.php?id=1106
Additional information:

Hide

Plan:
1. code to be changed is located in kDBEventHandler
2. idea is to replace 4 calls to getListSetting/setListSetting method with 1 call (to each method)

Show
Plan: 1. code to be changed is located in kDBEventHandler 2. idea is to replace 4 calls to getListSetting/setListSetting method with 1 call (to each method)
Change Log Message:
Reduces perform db query count
Story Points:
1
External issue ID:
1106
Copy Issue Key:
Patch Instructions:
Patches must be submitted through Phabricator.
- To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial
- To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial

In Admin Console In-Portal makes 4 requests to database during each list-style template display. For example on Phrases list such requests are made:

SELECT VariableValue, VariableName
FROM PersistantSessionData
WHERE VariableName = 'lang_Sort1.' AND PortalUserId = -1
LIMIT 0,1

SELECT VariableValue, VariableName
FROM PersistantSessionData
WHERE VariableName = 'lang_Sort1_Dir.' AND PortalUserId = -1
LIMIT 0,1

SELECT VariableValue, VariableName
FROM PersistantSessionData
WHERE VariableName = 'lang_Sort2.' AND PortalUserId = -1
LIMIT 0,1

SELECT VariableValue, VariableName
FROM PersistantSessionData
WHERE VariableName = 'lang_Sort2_Dir.' AND PortalUserId = -1
LIMIT 0,1

If we change sorting to be stored in one persistent session variable instead of 4 in "FieldName1,order1|FieldName,order2...." format, then we:

1. save 3 requests to database each time