Uploaded image for project: 'In-Portal CMS'
  1. In-Portal CMS
  2. INP-999

Email event usage refactoring

    XMLWordPrintable

    Details

      Description

      Currently e-mail event sending process (internally) doesn't represent real world model, which makes it hard to improve this code with new features.

      I'm proposing to:
      1. create kEmail class with following public methods:

      • findEvent($name, $type)
      • setParams($params)
      • send()
        2. make $this->sender refer to kEmailSendingHelper class instance for easy access across all methods
        3. move existing code from EmailEventsEventHandler into new kEmail class
        4. replace OnEmailEvent event sending with new kEmail class usage

      At the end interface of kApplication::EmailEventUser and kApplication::EmailEventAdmin will be almost the same (will return true/false instead of kEvent object), so no need to change code to make it working again.

      Usually nobody relies on e-mail sent fact in their code anyway.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                alex Alex
                Reporter:
                alex Alex
                Developer:
                Alex
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: