Uploaded image for project: 'In-Commerce'
  1. In-Commerce
  2. MINC-168

Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method

    XMLWordPrintable

    Details

    • Type: Bug Report
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2.2-B1
    • Component/s: General
    • Labels:
      None
    • Change Log Group:
      Changed
    • Change Log Message:
      The "OrderHelper::getCreditCartType" method was renamed into "OrderHelper::getCreditCardType" method.
    • Story Points:
      1
    • Copy Issue Key:
    • Patch Instructions:

      Patches must be submitted through Phabricator.

      Description

      Plan:

      1. rename "OrderHelper::getCreditCartType" method into "OrderHelper::getCreditCardType" (+fix all usage places)
      2. add "OrderHelper::getCreditCartType" method (yes, old name) that would (to preserve BC):
        • have the "@depricated" annotation in DocBlock
        • trigger silenced deprecation notice telling that "OrderHelper::getCreditCardType" method should be used instead
        • return result of calling "OrderHelper::getCreditCardType" method

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                alex Alex
                Reporter:
                alex Alex
                Developer:
                Erik Snarski [Intechnic]
                Reviewer:
                Alex
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: