Uploaded image for project: 'In-Portal CMS'
  1. In-Portal CMS
  2. INP-1046

Change "getFrame" JavaScript function to prevent it looking outside of frameset

    XMLWordPrintable

    Details

    • Type: Bug Report
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.3.9
    • Fix Version/s: 5.2.0-RC1
    • Component/s: Admin Interfaces
    • Labels:
      None

      Description

      In-Portal uses getFrame method to reach it's main window (when working with Admin Console) by intellectually traversing through all opened windows and frames (see "getFrame" javascript method).

      However this "getFrame" method can return a reference outside Admin Console frameset at all. For example to a window/tab, that had a link to an Admin Console.

      There are 2 ways to prevent this:
      don't check for window.opener when we're already in frameset main window
      check if found window.location.hostname of found window is the same as one we're started traversing with (basically same domain+base_path)

      Without this if you're opening in-portal windows using links on other websites and not by directly typing url you might see problem described above.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                alex Alex
                Reporter:
                dmitry Dmitry Andrejev [Intechnic]
                Developer:
                Alex
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: