Fixed
Details
Priority
MinorAssignee
AlexAlexReporter
AlexAlexDeveloper
AlexAlexChange Log Message
Changed only UTF-8 is allowedPatch Instructions
Patches must be submitted through Phabricator.
To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial.
To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial.
External issue ID
1342External issue URL
BC Break Details
Removed methods:
"LanguagesTagProcessor::GetCharset"
Story Points
1Fix versions
Affects versions
Details
Details
Priority
Assignee
Alex
AlexReporter
Alex
AlexDeveloper
Alex
AlexChange Log Message
Changed only UTF-8 is allowed
Patch Instructions
Patches must be submitted through Phabricator.
To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial.
To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial.
External issue ID
1342
External issue URL
BC Break Details
Removed methods:
"LanguagesTagProcessor::GetCharset"
Story Points
1
Fix versions
Affects versions
Created July 9, 2012 at 4:16 PM
Updated December 30, 2024 at 2:26 AM
Resolved September 16, 2012 at 9:45 AM
In-Portal always allowed to enter custom charset for each language you've add. However from time, when we implemented this feature a lot has changed and now UTF-8 is major charset that supports all of them together.
I propose to remove Charset from Language settings and always use UTF-8.
I'm proposing this because recently I had a need to do some symbol conversions in OnAfterConfigRead event, which is called before actual charset from a language is detected and mb_internal_encoding is set.
For backwards compatibility we still can support "one-per-system" charset setting in config.php (like we do now with database), but not "each language have it's own charset" system, that is bad.