Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Support for user-defined fields in "st_CachedMenu" tag

Components

Labels

Description

Right now we have nice <inp2:st_CachedMenu .../> tag, that prints every menu on website without doing a database query.
This works good, however in some projects I came across situations where a new database field (e.g. extra css class name) was added to a page (category) and this field needs to be used during menu printing.

This requires to override 2 methods in MenuHelper class.

I'm proposing to create an array (as a property of MenuHelper class), where mapping is created between Categories database table fields and parameter names, used to retrieve their values from template.

Here is an example array:

Array ( 'parent_path' => 'ParentPath', 'icon' => Array ('Icon', 'resize:100x100'), );

Then these parameters would be used with GetField method.

Context Information

None

Additional information (do not use)

Also need to reset menu cache, when either of these new fields will be changed in a category record.

Confluence content

mentioned on

Activity

Show:

Alex July 25, 2016 at 9:12 AM

alex closed D196: https://in-portal.atlassian.net/browse/INP-1157#icft=INP-1157 - Support for user-defined fields in "st_CachedMenu" tag by committing rINP16381: Fixes https://in-portal.atlassian.net/browse/INP-1157#icft=INP-1157 - Support for user-defined fields in "st_CachedMenu" tag.
alex updated the diff for D196: https://in-portal.atlassian.net/browse/INP-1157#icft=INP-1157 - Support for user-defined fields in "st_CachedMenu" tag.

[API] Administrator July 25, 2016 at 9:12 AM

User committed a fix to 5.3.x. Commit Message:

Fixes https://in-portal.atlassian.net/browse/INP-1157#icft=INP-1157 - Support for user-defined fields in "st_CachedMenu" tag

Differential Revision: http://qa.in-portal.org/D196

Alex July 25, 2016 at 9:09 AM

alex updated the diff for D196: https://in-portal.atlassian.net/browse/INP-1157#icft=INP-1157 - Support for user-defined fields in "st_CachedMenu" tag.
D196: https://in-portal.atlassian.net/browse/INP-1157#icft=INP-1157 - Support for user-defined fields in "st_CachedMenu" tag is now accepted and ready to land.
alex added a comment to D196: https://in-portal.atlassian.net/browse/INP-1157#icft=INP-1157 - Support for user-defined fields in "st_CachedMenu" tag.

Removed non-related debugging code changes.

Alex July 25, 2016 at 9:05 AM

alex planned changes to D196: https://in-portal.atlassian.net/browse/INP-1157#icft=INP-1157 - Support for user-defined fields in "st_CachedMenu" tag.
alex added a comment to D196: https://in-portal.atlassian.net/browse/INP-1157#icft=INP-1157 - Support for user-defined fields in "st_CachedMenu" tag.

The changes to all but `menu_helper.php` file needs to be removed, because it's a debug code.

Alex July 15, 2016 at 7:41 PM

alex retitled D196: https://in-portal.atlassian.net/browse/INP-1157#icft=INP-1157 - Support for user-defined fields in "st_CachedMenu" tag, from "INP-1157 - MenuHelper improvements" to "INP-1157 - Support for user-defined fields in "st_CachedMenu" tag".

Fixed

Details

Priority

Assignee

Reporter

Developer

Reviewer

Change Log Group

Added

Change Log Message

Patch Instructions

Patches must be submitted through Phabricator.

Time tracking

4m logged

External issue ID

External issue URL

http://tracker.in-portal.org/view.php?id=1400

Story Points

Fix versions

Affects versions

Created September 16, 2012 at 11:47 AM
Updated December 29, 2024 at 8:53 PM
Resolved July 25, 2016 at 9:12 AM

Flag notifications