Skip to:

Skip to Jira Navigation
Skip to Side Navigation
Skip to Main Content

Use "E-mail Templates" term in codebase instead of "E-mail Events"

Components

Labels

Description

1. In-Portal has "E-mail Templates" section, where all e-mail templates are defined.
Later via special function call developer can render each of templates and send result to e-mail address given.

But internally we call them as "e-mail events". I think we should do some renaming to have "e-mail templates" term across the system.

2. We also validate, during e-mail sending, that supplied e-mail event name has only upper case letters and dots, but we don't validate the same upon e-mail event adding/editing.

This way it's possible to enter e-mail event name, that won't be sent just because it's named incorrectly.

Context Information

None

Additional information (do not use)

None

Attachments

2

Linked issues

parent of

Add "LA_FLD_EVENT" label

Detect primary key of "email-template" unit automatically during upgrade

relates to

Replace "emailevents" with "email-template" in 5.3.x upgrade script

Activity

Alex July 20, 2015 at 11:15 AM

Closing issues from released versions.

Alex November 6, 2012 at 5:21 PM

Fix committed to [b]5.2.x branch/b. Commit Message:

Fixes #0001424: Inconsistent naming in "E-mail Templates" section

Alex November 6, 2012 at 5:13 PM

Will test all together later.

Fixed

Details
Priority
Minor
Assignee
Alex
Reporter
Alex
Developer
Alex
Change Log Group
Changed
Change Log Message
Renamed "e-mail events" into "e-mail templates". Renamed "kApplication::EmailEventAdmin" into "kApplication::emailAdmin". Renamed "kApplication::EmailEventUser" into "kApplication::emailUser".
Patch Instructions
Patches must be submitted through Phabricator.
To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial.
To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial.
External issue ID
1424
External issue URL
BC Break Details
Renamed units:
"emailevents" into "email-template"
Renamed classes:
"EmailEventsEventsHandler" into "EmailTemplateEventHandler"
"EmailEventTagProcessor" into "EmailTemplateTagProcessor"
"kEmailMessageHelper" into "kEmailTemplateHelper"
Renamed methods:
"PhraseTagProcessor::EventCount" into "PhraseTagProcessor::TemplateCount"
Story Points
1
Fix versions
5.2.1-B1
Affects versions
5.1.3

Created November 5, 2012 at 9:38 AM

Updated December 30, 2024 at 2:00 AM

Resolved November 6, 2012 at 5:21 PM