Uploaded image for project: 'In-Portal CMS'
  1. In-Portal CMS
  2. INP-1267

Make methods public in "kDBBase" class sub-classes also public in "kDBBase" class itself

    XMLWordPrintable

    Details

    • Type: Bug Report
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2.1-RC1
    • Component/s: Data Management
    • Labels:
      None
    • Change Log Group:
      Changed
    • Change Log Message:
      Made protected methods "kDBBase" class publicly accessible, when in sub-classes they were public.
    • Story Points:
      1
    • Copy Issue Key:
    • Patch Instructions:

      Patches must be submitted through Phabricator.

      Description

      When developer wants his method to accept both list & item object, then he needs to use kDBBase´╗┐ class for type hinting like this:

      public function getBuildParams(kDBBase $object)
      {
      	$value = $object->GetDBField('FieldName'); // doesn't auto-complete
      }
      

      However because of all abstract methods in kDBBase class (including method GetDBField above) has protected´╗┐ access they are not auto-completed by IDE.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                alex Alex
                Reporter:
                alex Alex
                Developer:
                Alex
                Reviewer:
                Dmitry Andrejev [Intechnic]
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: