Improve cross-browser support in Category Item Selector

Components

Labels

Description

Category/category item selector has 2 modes: "Show All" and "Show Structure". It is possible switch the mode clicking on a text itself, but not possible by clicking directly on the radio button.

Selector is used for example during relation adding to the category.

Context Information

None

Additional information (do not use)

None

Attachments

Linked issues

is backported by

INP-1623

Improve cross-browser support in Category Item Selector

Activity

Show:

[API] Administrator July 30, 2013 at 7:36 AM

User @Alex committed a fix to 5.3.x. Commit Message:

Fixes https://in-portal.atlassian.net/browse/INP-1285#icft=INP-1285 - Unable to change category/category item selector mode

Alex July 30, 2013 at 7:35 AM

OK.

Alex July 30, 2013 at 7:35 AM

The original control in general is wrong, because clicking on radio button can't really trigger page reload.

I've rearranged the code to be valid (from HTML viewpoint) and working.

Alex July 30, 2013 at 7:35 AM

Only text or image is allowed inside A tag. This way placing radio button alongside with it's associated label within A tag is incorrect approach.

Erik S. July 25, 2013 at 5:13 PM

All done. Patch attached:
catalog_selector_mode_fix.patch 25/Jul/13 8:11 PM 1 kB

Ready for Testing

Fixed

Details
Priority
Minor
Assignee
Alex
Reporter
Alex
Developer
Alex
Reviewer
Dmitry Andrejev
Change Log Group
Fixed
Change Log Message
The mode selector (between "Show All" and "Show Structure") wasn't working in category item selector.
Patch Instructions
Patches must be submitted through Phabricator.
To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial.
To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial.
Commit Revision
15,921
Story Points
1
Fix versions
5.3.0-B1

Created July 4, 2013 at 2:43 PM

Updated December 29, 2024 at 8:59 PM

Resolved July 30, 2013 at 7:36 AM