Use "http_build_query" to escape url parameters

Components

Labels

Description

Use "http_build_query" to escape url parameters in kApplication::HREF method and it's derivatives.

Also replace "%23" back to "#" to ensure compatibility with JS code, that uses "#variable#" alike substitutions.

Context Information

None

Additional information (do not use)

None

Attachments

3

Activity

[API] Administrator October 3, 2013 at 12:14 PM

User committed a fix to 5.3.x. Commit Message:

Fixes - Use "http_build_query" to escape url parameters

Alex October 3, 2013 at 12:08 PM

Dmitry will test all together later.

Alex October 3, 2013 at 11:56 AM

Changes required to custom-code after this task is commited:

  1. __URLENCODE__ parameter is no longer supported by (use no_amp parameter instead):

    • kApplication::HREF method

    • m_Link, m_t tags or they derivatives

  2. no_amp parameter is now only supported in (only use in tags alongside with js_escape parameter):

    • m_Link, m_t tags or they derivatives

  3. escape parameter is no longer supported by (use js_escape parameter instead):

    • kApplication::HREF method

    • m_Link, m_t tags or they derivatives

P.S.

If you see no_amp or __URLENCODE__ parameter in resulting url, then see a solution proposed above.

Alex September 19, 2013 at 3:20 PM

An interesting side effect, after implementing proposed idea, popped up: "\" is encoded as %5C automatically resulting in 100% valid url escaped for usage in JavaScript without a need to pass js_escape="1" to <inp2:m_Link .../> tag.

Before single slash ("\") was left as is and using js_escape="1" parameter converted it to double slashes.

Alex September 16, 2013 at 5:40 PM

Migrating issues to new workflow.

Fixed

Details

Priority

Assignee

Reporter

Developer

Reviewer

Change Log Group

Changed

Change Log Message

Patch Instructions

Patches must be submitted through Phabricator.

Story Points

Sprint

Fix versions

Created July 17, 2013 at 11:03 AM
Updated December 30, 2024 at 2:26 AM
Resolved October 3, 2013 at 12:14 PM