Details

Priority

Minor

Assignee

Alex

Reporter

Alex

Developer

Erik S.

Reviewer

Alex

Change Log Group

Removed

Change Log Message

Use PHP built-in date functions instead of adodb library.

Patch Instructions

Patches must be submitted through Phabricator.

• To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial.

• To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial.

BC Break Details

ADOdb Date/Time Library: http://adodb.org/dokuwiki/doku.php?id=v5:datetime:datetime_index

Functions Deleted (internal):

• "_adodb_getdate"

• "_adodb_is_leap_year"

• "adodb_date_test_date"

• "adodb_date_test_strftime"

• "adodb_dow"

• "adodb_get_gmt_diff"

• "adodb_is_leap_year"

• "adodb_year_digit_check"

Functions Deleted (public):

• "adodb_date"

• "adodb_date2"

• "adodb_getdate"

• "adodb_gmdate"

• "adodb_gmmktime"

• "adodb_gmstrftime"

• "adodb_mktime"

• "adodb_strftime"

Constants Deleted:

• "ADODB_DATE_VERSION"

Solution

1. restore deleted "/core/kernel/utility/adodb-time.inc.php" file and it's inclusion in "/core/kernel/startup.php"

2. in restore file only keep definitions of public deleted functions (see BC break description) and constants

3. for kept public functions:

   • add "@deprecated 5.3.0-B1" (the version where change is released)

   • add "@see time()" (the function name that should be used instead)

   • call to "kUtil::deprecatedMethod" method (as in http://qa.in-portal.org/D276)

   • return result of calling native PHP function

Story Points

1

Fix versions

5.3.0-B1