Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Remove closing php tags in all files

Components

Labels

Description

PHP documentation says, that closing php tag ("?>") is not required for files, that contains only php code. Additionally not placing closing php tag [b]at the end/b of php files prevent user's from accidentally adding new lines after it resulting in inability to properly send headers (like cookies, redirects etc.) during script work.

Context Information

None

Additional information (do not use)

None

Activity

Dmitry Andrejev January 12, 2010 at 4:05 AM

Closing completed tasks.

Dmitry Andrejev October 31, 2009 at 8:12 PM

Fix committed to [b]5.0.x branch/b. Commit Message:

Fixes https://in-portal.atlassian.net/browse/INP-135#icft=INP-135: Remove closing php tags in all files

Alex October 31, 2009 at 6:22 PM

I think, that we should, because when we were replacing include/require to be all with absolute paths, then we fixed fck as well.

Dmitry Andrejev October 31, 2009 at 6:16 PM

Are you sure we want to removed them since it's 3rd party software and I don't think we'll be changing it a lot which means it will stay unchanged until the next upgrade of FCK...

Let me know if I still should remove it there.

Alex October 31, 2009 at 10:37 AM

There are 20 files with "?>" tag, but not all of them have it in file end. But files from this folder definitely have it:

/core/editor/editor/filemanager/connectors/php/

Fixed

Details

Priority

Assignee

Reporter

Patch Instructions

Patches must be submitted through Phabricator.

External issue ID

External issue URL

http://tracker.in-portal.org/view.php?id=167

Fix versions

Affects versions

Created August 1, 2009 at 11:39 AM
Updated December 29, 2024 at 9:24 PM
Resolved January 12, 2010 at 4:05 AM

Flag notifications