PHP 7 compatibility issues (5.3.x)

Components

Labels

Description

Fix occurrences of following:

usages of $this->$property['prop'] (e.g. in kDBList)
usage of references inside foreach
classes having method named the same as class name (the PHP4 constructor) are now deprecated
usage of $HTTP_RAW_POST_DATA

Context Information

None

Additional information (do not use)

None

Linked issues

is backported by

INP-1607

PHP 7 compatibility issues (5.3.x)

parent of

INP-1502

Gracefully handle case of missing file/line keys in stack trace info

Activity

Alex September 1, 2015 at 8:21 AM

alex closed D79: - PHP 7 compatibility issues by committing rINP16226: Fixes - PHP 7 compatibility issues.
alex updated the diff for D79: - PHP 7 compatibility issues.

http://qa.in-portal.org/D79

[API] Administrator September 1, 2015 at 8:21 AM

User committed a fix to 5.3.x. Commit Message:

Fixes - PHP 7 compatibility issues

Differential Revision: http://qa.in-portal.org/D79

Alex September 1, 2015 at 8:13 AM

alex updated the diff for D79: - PHP 7 compatibility issues.
D79: - PHP 7 compatibility issues is now accepted and ready to land.
alex added a comment to D79: - PHP 7 compatibility issues.

Replaced PHP4-style constructors in a few more classes.

http://qa.in-portal.org/D79

Alex September 1, 2015 at 8:03 AM

alex planned changes to D79: - PHP 7 compatibility issues.
alex added a comment to D79: - PHP 7 compatibility issues.

Turns out I've forgot to update 2 more files having PHP4-style constructors in them:

core/units/helpers/json_helper.php
core/units/categories/cache_updater.php

http://qa.in-portal.org/D79

Gleb Sinkovskiy June 17, 2015 at 8:07 AM

glebs accepted D79: - PHP 7 compatibility issues.
D79: - PHP 7 compatibility issues is now accepted and ready to land.

http://qa.in-portal.org/D79

Fixed

Details
Priority
Minor
Assignee
Alex
Reporter
Alex
Developer
Alex
Reviewer
Gleb Sinkovskiy
Change Log Group
Fixed
Change Log Message
Make code 100% compatible with PHP 7.
Patch Instructions
Patches must be submitted through Phabricator.
To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial.
To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial.
Commit Revision
16,226
Story Points
1
Fix versions
5.3.0-B1

Created May 30, 2015 at 9:47 PM

Updated December 29, 2024 at 11:27 PM

Resolved September 1, 2015 at 8:21 AM