[INP-1509] Change concept used for category path matching to module root category - In-Portal Issue Tracker

XML

Word

Printable

Change Log Group:
Fixed
Change Log Message:
Module tab in Catalog wasn't activated when module category was selected in category tree.
Story Points:
1
Copy Issue Key:
Patch Instructions:
Patches must be submitted through Phabricator.
- To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial
- To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial
BC Break Details:
Hide

Deleted methods:

"CategoryHelper::getModuleRootCategories"

Return value changed:

the "CategoryHelper::getCategoryModule" returns "array();" instead of "false", when module isn't found.

Solution

make "CategoryHelper::getCategoryModule" return "false" when no match was found.
Show
Deleted methods: "CategoryHelper::getModuleRootCategories" Return value changed: the "CategoryHelper::getCategoryModule" returns "array();" instead of "false", when module isn't found. Solution make "CategoryHelper::getCategoryModule" return "false" when no match was found.

Change "CategoryHelper::getCategoryModule" to compare each of given categories in reverse order to each module category.

bc break fixed by

INP-1661 Check "CategoryHelper::getCategoryModule" method call result before using it

implemented in

D161 INP-1509 - Change concept used for category path matching to module root category

Solution