Don't attach same file twice to same e-mail

Components

Labels

None

Description

The "kEmailSendingHelper::AddAttachment" method needs to only add new e-mail part (call the "AddPart" method), when no part with exactly same definition exists in that email already.

Context Information

None

Additional information (do not use)

None

Linked issues

relates to

INP-1528

When attaching file to e-mail verify, that it's a file, not a directory

Activity

Alex November 28, 2016 at 9:26 AM

Closing issues of a released version.

Alex July 12, 2016 at 7:49 AM

alex closed D191: - Don't attach same file twice to same e-mail by committing rINP16362: Fixes - Don't attach same file twice to same e-mail.
alex updated the diff for D191: - Don't attach same file twice to same e-mail.

[API] Administrator July 12, 2016 at 7:49 AM

User committed a fix to 5.2.x. Commit Message:

Fixes - Don't attach same file twice to same e-mail

Differential Revision: http://qa.in-portal.org/D191

Alex March 10, 2016 at 11:15 AM

alex added a project to D191: - Don't attach same file twice to same e-mail: Intechnic: RPI.

Gleb Sinkovskiy February 19, 2016 at 8:27 AM

glebs accepted D191: - Don't attach same file twice to same e-mail.
D191: - Don't attach same file twice to same e-mail is now accepted and ready to land.

Fixed

Details
Priority
Minor
Assignee
Alex
Reporter
Alex
Developer
Alex
Reviewer
Gleb Sinkovskiy
Change Log Group
Fixed
Change Log Message
The "m_AttachFile" tag was attaching same file twice to the e-mail.
Patch Instructions
Patches must be submitted through Phabricator.
To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial.
To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial.
Story Points
1
Fix versions
5.2.2-B1

Created January 30, 2016 at 10:59 AM

Updated December 29, 2024 at 8:54 PM

Resolved July 12, 2016 at 7:49 AM