[INP-1557] Use "http_build_query" to escape url parameters - In-Portal Issue Tracker

XML

Word

Printable

Change Log Group:
Changed
Change Log Message:
Urlencode whole Query String of links, not just "&" symbol. Drop support for "__URLENCODE__" link parameter.
Copy Issue Key:
Patch Instructions:
Patches must be submitted through Phabricator.
- To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial
- To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial
BC Break Details:
Hide

Removed:

support of "escape" parameter for "m_t" and "m_Link" tag, that did js-escaping when used

support of "__URLENCODE__" parameter for "m_t" and "m_Link" tag, that probably prevented html-encoding of url and js-encoding it as same time

Changed:

the "no_amp" parameter (also named as "__URLENCODE__") for "m_t" and "m_Link" tag was preventing html-escaping and doing js escaping at same time, but now it doesn't do automatic js escaping
Show
Removed: support of "escape" parameter for "m_t" and "m_Link" tag, that did js-escaping when used support of "__ URLENCODE __" parameter for "m_t" and "m_Link" tag, that probably prevented html-encoding of url and js-encoding it as same time Changed: the "no_amp" parameter (also named as "__ URLENCODE __") for "m_t" and "m_Link" tag was preventing html-escaping and doing js escaping at same time, but now it doesn't do automatic js escaping

backports

INP-1298 Use "http_build_query" to escape url parameters

blocks

TADV-50 Use "http_build_query" to escape url parameters

TDEF-12 Use "http_build_query" to escape url parameters

TSIM-9 Use "http_build_query" to escape url parameters

parent of

INP-1558 Escape page urls in internal page dropdown of CKEditor

(2 mentioned in)