Change semaphores to allow concurrent editing of different DB records

Components

Data Management

Labels

None

Description

Plan:

add "MainIDs" column (text, null) to "Semaphores" table - 0.2h
when creating a semaphore ("kTempTablesHandler::SaveEdit" method) store main table IDs comma-separated form in the new "Semaphores.MainIDs" table - 0.3h
when checking for existing semaphores exclude semaphore, when: - 1h
- the copied IDs (will go into "MainIDs" column if semaphore is created) do not overlap with IDs in the semaphore
- the "MainIDs" column of the semaphore has "0" value (in main temp table new created record always has 0 as its ID due missing auto-increment column)

Quote: 1.5h*1.4=2h

Context Information

None

Additional information (do not use)

None

Linked issues

blocks

INP-1780

Sync "Semaphores" table structure between clean install and upgrade

Activity

Show:

Alex December 16, 2019 at 1:42 PM

alex added inline comments to D237: - Change semaphores to allow concurrent editing of different DB records.

Inline Comments
branches/5.2.x/core/install/upgrades.sql:2937 Discovered bug (after release), that "MainIDs" column during In-Portal 5.2.2-B1 upgrade is created as "INT" instead of "TEXT".

Alex November 28, 2016 at 9:26 AM

Closing issues of a released version.

Alex November 24, 2016 at 8:47 PM

alex closed D237: - Change semaphores to allow concurrent editing of different DB records by committing rINP16468: Fixes - Change semaphores to allow concurrent editing of different….
alex updated the diff for D237: - Change semaphores to allow concurrent editing of different DB records.

[API] Administrator November 24, 2016 at 8:47 PM

User committed a fix to 5.2.x. Commit Message:

Fixes - Change semaphores to allow concurrent editing of different DB records

Differential Revision: http://qa.in-portal.org/D237

Erik S. July 19, 2016 at 11:24 AM

erik accepted D237: - Change semaphores to allow concurrent editing of different DB records.
D237: - Change semaphores to allow concurrent editing of different DB records is now accepted and ready to land.

Fixed

Details
Priority
Minor
Assignee
Alex
Reporter
Alex
Developer
Alex
Reviewer
Erik S.
Change Log Group
Fixed
Change Log Message
Saving changes to different DB records from same table wasn't possible due when semaphore protection.
Patch Instructions
Patches must be submitted through Phabricator.
To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial.
To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial.
Time tracking
1h 48m logged12m remaining
Story Points
1
Original estimate
2h
Fix versions
5.2.2-B1

Created July 15, 2016 at 2:44 PM

Updated December 29, 2024 at 8:52 PM

Resolved November 24, 2016 at 8:47 PM