[INP-1678] [bc fix] Simplify "kEvent" class constructor - In-Portal Issue Tracker

XML

Word

Printable

Change Log Group:
Deprecated
Change Log Message:
Deprecated "$params" and "$specific_params" of "kApplication::HandleEvent" method.
Story Points:
1
Copy Issue Key:
Patch Instructions:
Patches must be submitted through Phabricator.
- To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial
- To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial

in "kApplication::HandleEvent" method:
- add "$params" and "$specific_params" parameters back, but add "array" type hint to them
- when "$params" parameter is an array, then
  - use "kUtil::deprecateParameter" method to trigger notice about usage of $params/$specific_params parameters
  - use "kEvent::fromArray" method to create event, that will replace "$event" parameter value
extract logic, that transforms "$params" array into string from public static "kEvent::fromArray" into protected static "kEvent::arrayToString" method
in "kEvent::__construct" method, when "$event_string" argument turns out to be an array:
- use "kUtil::deprecateParameter" method to trigger notice about usage of $params parameter
- use "kEvent::arrayToString" to transform "$event_string" parameter value

fixes bc break of

INP-1462 Simplify "kEvent" class constructor