Uploaded image for project: 'In-Portal CMS'
  1. In-Portal CMS
  2. INP-1686

Don't include timestamp in compiled Admin Skin file

    XMLWordPrintable

    Details

    • Change Log Group:
      Changed
    • Change Log Message:
      Changed filename format of compiled Admin Skin CSS file.
    • Story Points:
      1
    • Copy Issue Key:
    • Patch Instructions:

      Patches must be submitted through Phabricator.

    • BC Break Details:
      Hide

      Constants Deleted:

      • SkinHelper::SKIN_REGEXP (used only by method, that was deleted)

      Methods Deleted (both methods used as "protected", but were missing scope in their declaration):

      • SkinHelper::_getLastCompiled
      • SkinHelper::isSkinFile

      Method Scope Reduced:

      • SkinHelper::_getStyleField (was "public" now "protected")

      Method Signature Changed:

      • SkinHelper::AdminSkinTag (because this is tag)
        OLD: $params
        NEW: array $params
      • SkinHelper::compile
        OLD: &$object
        NEW: \kDBItem $object
      • SkinHelper::getSkinPath (parameter isn't used now)
        OLD: $url = false, $compile_date = NULL
        NEW: $url = false
      Show
      Constants Deleted: SkinHelper::SKIN_REGEXP (used only by method, that was deleted) Methods Deleted (both methods used as "protected", but were missing scope in their declaration): SkinHelper::_getLastCompiled SkinHelper::isSkinFile Method Scope Reduced: SkinHelper::_getStyleField (was "public" now "protected") Method Signature Changed: SkinHelper::AdminSkinTag (because this is tag) OLD: $params NEW: array $params SkinHelper::compile OLD: &$object NEW: \kDBItem $object SkinHelper::getSkinPath (parameter isn't used now) OLD: $url = false, $compile_date = NULL NEW: $url = false

      Description

      1. change "SkinHelper::compile" method to:
        1. don't include timestamp into compiled filename
        2. don't delete previous version of skin file
      2. delete "SkinHelper::SKIN_REGEXP" constant
      3. delete "SkinHelper::isSkinFile" method
      4. delete "SkinHelper::_getLastCompiled" method
      5. change "SkinHelper::AdminSkinTag" to compile file, when missing and return it in either case

        Attachments

          Issue Links

          relates to

          Bug Report - A problem which impairs or prevents the functions of the product. INP-1687 Use Assetic for asset management

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Scheduled
          implemented in

          [Phabricator] Phabricator [Diffusion] rINP16568 Fixes INP-1686 - Don't include timestamp in compiled Admin Skin file

          [Phabricator] Phabricator D292 INP-1686 - Don't include timestamp in compiled Admin Skin file

          mentioned in

          Page Loading...

            Activity

              People

              • Assignee:
                alex Alex
                Reporter:
                alex Alex
                Developer:
                Alex
                Reviewer:
                Erik Snarski [Intechnic]
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2h
                  2h