Skip to:

Skip to Jira Navigation
Skip to Side Navigation
Skip to Main Content

Don't include timestamp in compiled Admin Skin file

Components

Admin Interfaces

Labels

Description

change "SkinHelper::compile" method to:
1. don't include timestamp into compiled filename
2. don't delete previous version of skin file
delete "SkinHelper::SKIN_REGEXP" constant
delete "SkinHelper::isSkinFile" method
delete "SkinHelper::_getLastCompiled" method
change "SkinHelper::AdminSkinTag" to compile file, when missing and return it in either case

Context Information

None

Additional information (do not use)

None

Linked issues

relates to

Use Assetic for asset management

Activity

Show:

Alex July 16, 2017 at 6:10 PM

ci added a comment to rINP16568: Fixes https://in-portal.atlassian.net/browse/INP-1686#icft=INP-1686 - Don't include timestamp in compiled Admin Skin file.

Build *#149* finished with *UNSTABLE* status: http://ci.in-portal.org/job/in-portal-52x_modules/149/

Checkstyle Warnings: *4*

Alex July 16, 2017 at 5:59 PM

alex committed rINP16568: Fixes https://in-portal.atlassian.net/browse/INP-1686#icft=INP-1686 - Don't include timestamp in compiled Admin Skin file.

Fixes https://in-portal.atlassian.net/browse/INP-1686#icft=INP-1686 - Don't include timestamp in compiled Admin Skin file

Differential Revision: http://qa.in-portal.org/D292

Alex July 16, 2017 at 5:59 PM

alex updated rINP16568: Fixes https://in-portal.atlassian.net/browse/INP-1686#icft=INP-1686 - Don't include timestamp in compiled Admin Skin file.

Alex July 16, 2017 at 5:59 PM

alex closed D292: https://in-portal.atlassian.net/browse/INP-1686#icft=INP-1686 - Don't include timestamp in compiled Admin Skin file by committing rINP16568: Fixes https://in-portal.atlassian.net/browse/INP-1686#icft=INP-1686 - Don't include timestamp in compiled Admin Skin file.
alex updated the diff for D292: https://in-portal.atlassian.net/browse/INP-1686#icft=INP-1686 - Don't include timestamp in compiled Admin Skin file.

[API] Administrator July 16, 2017 at 5:59 PM

User committed a fix to 5.2.x. Commit Message:

Fixes https://in-portal.atlassian.net/browse/INP-1686#icft=INP-1686 - Don't include timestamp in compiled Admin Skin file

Differential Revision: http://qa.in-portal.org/D292

Fixed

Details
Priority
Minor
Assignee
Alex
Reporter
Alex
Developer
Alex
Reviewer
Erik S.
Change Log Group
Changed
Change Log Message
Changed filename format of compiled Admin Skin CSS file.
Patch Instructions
Patches must be submitted through Phabricator.
To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial.
To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial.
Time tracking
2h logged
BC Break Details
Constants Deleted:
SkinHelper::SKIN_REGEXP (used only by method, that was deleted)
Methods Deleted (both methods used as "protected", but were missing scope in their declaration):
SkinHelper::_getLastCompiled
SkinHelper::isSkinFile
Method Scope Reduced:
SkinHelper::_getStyleField (was "public" now "protected")
Method Signature Changed:
SkinHelper::AdminSkinTag (because this is tag)
OLD: $params
NEW: array $params
SkinHelper::compile
OLD: &$object
NEW: \kDBItem $object
SkinHelper::getSkinPath (parameter isn't used now)
OLD: $url = false, $compile_date = NULL
NEW: $url = false
Story Points
1
Fix versions
5.2.2-B2

Created March 19, 2017 at 9:55 AM

Updated December 29, 2024 at 8:51 PM

Resolved July 16, 2017 at 5:59 PM