Support both "%s" and "{param_name}" in validation error messages

Components

Admin Interfaces

Labels

None

Description

In the "kValidator::GetErrorMsg" method, when "$params" (error message params) array:

when error message contains "%" that is followed by non-whitespace symbol we execute old code (get from SVN), where "sprintf" was used
otherwise execute current code with " {param_name}" replacement

At the end both approach should work, since we're not planning to deprecate "%s" approach in error messages.

Context Information

None

Additional information (do not use)

None

Linked issues

fixes bc break of

INP-1380

Use named parameters in error messages and add new parameter {field}

Activity

Alex July 16, 2017 at 6:15 PM

ci added a comment to rINP16569: Fixes - Support both "%s" and "{param_name}" in validation error….

Build *#131* finished with *UNSTABLE* status: http://ci.in-portal.org/job/in-portal-52x/131/

Alex July 16, 2017 at 6:04 PM

alex updated rINP16569: Fixes - Support both "%s" and "{param_name}" in validation error….

Alex July 16, 2017 at 6:04 PM

alex committed rINP16569: Fixes - Support both "%s" and "{param_name}" in validation error….

Fixes - Support both "%s" and "{param_name}" in validation error messages

Differential Revision: http://qa.in-portal.org/D293

Alex July 16, 2017 at 6:04 PM

alex closed D293: - Support both "%s" and "{param_name}" in validation error messages by committing rINP16569: Fixes - Support both "%s" and "{param_name}" in validation error….
alex updated the diff for D293: - Support both "%s" and "{param_name}" in validation error messages.

[API] Administrator July 16, 2017 at 6:04 PM

User committed a fix to 5.2.x. Commit Message:

Fixes - Support both "%s" and "{param_name}" in validation error messages

Differential Revision: http://qa.in-portal.org/D293

Fixed

Details
Priority
Minor
Assignee
Alex
Reporter
Alex
Developer
Alex
Reviewer
Erik S.
Change Log Group
Fixed
Change Log Message
Date format wasn't shown in validation messages.
Patch Instructions
Patches must be submitted through Phabricator.
To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial.
To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial.
Time tracking
1h logged
Story Points
1
Fix versions
5.2.2-B2
Affects versions
5.2.2-B1

Created March 21, 2017 at 11:05 AM

Updated December 29, 2024 at 8:51 PM

Resolved July 16, 2017 at 6:04 PM