[bc fix] Asynchronous e-mail sending by default

Components

Labels

Description

for "kEmail::send" method:
1. add optional "$immediate_send" parameter back, but with "null" default value
2. when specified use it as-as during "\kEmailSendingHelper::Deliver" method call
restore "EmailTemplateEventHandler::OnProcessEmailQueue" method, but:
1. indicate, that it's deprecated now
2. replace it's body with new code
for "MailingListHelper::processQueue" method:
1. restore "$messages" parameter by make it optional
2. when "$messages" parameter isn't specified set it's value from "\MailingListHelper::getMessages" method
restore "\MailingListEventHandler::OnProcessEmailQueue" method, but:
1. indicate, that it's deprecated now
2. replace it's body with new code
restore "MailingListEventHandler::_ensureDefault" method, but:
1. indicate, that it's deprecated now
2. replace it's body with new code

Context Information

None

Additional information (do not use)

None

Linked issues

fixes bc break of

INP-1223

Asynchronous e-mail sending by default

is backported by

INP-1722

[bc fix] Asynchronous e-mail sending by default

Activity

Alex July 27, 2017 at 9:06 AM

ci added a comment to rINP16597: Fixes - [bc fix] Asynchronous e-mail sending by default.

Build *#53* finished with *UNSTABLE* status: http://ci.in-portal.org/job/in-portal-53x/53/

Checkstyle Warnings: *19*
PMD Warnings: *2*

Alex July 27, 2017 at 8:56 AM

alex updated rINP16597: Fixes - [bc fix] Asynchronous e-mail sending by default.

Alex July 27, 2017 at 8:56 AM

alex closed D313: - [bc fix] Asynchronous e-mail sending by default by committing rINP16597: Fixes - [bc fix] Asynchronous e-mail sending by default.
alex updated the diff for D313: - [bc fix] Asynchronous e-mail sending by default.

Alex July 27, 2017 at 8:56 AM

alex committed rINP16597: Fixes - [bc fix] Asynchronous e-mail sending by default.

Fixes - [bc fix] Asynchronous e-mail sending by default

Differential Revision: http://qa.in-portal.org/D313

[API] Administrator July 27, 2017 at 8:55 AM

User committed a fix to 5.3.x. Commit Message:

Fixes - [bc fix] Asynchronous e-mail sending by default

Differential Revision: http://qa.in-portal.org/D313

Fixed

Details
Priority
Minor
Assignee
Alex
Reporter
Alex
Developer
Alex
Reviewer
Erik S.
Change Log Group
Fixed
Change Log Message
Fixed BC breaks introduced in INP-1223.
Patch Instructions
Patches must be submitted through Phabricator.
To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial.
To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial.
Time tracking
5h 2m logged
Story Points
1
Fix versions
5.3.0-B1
Affects versions
5.3.0-B1

Created July 3, 2017 at 7:35 AM

Updated December 29, 2024 at 8:50 PM

Resolved July 27, 2017 at 8:55 AM