[INP-1751] Use PHP5-style constructor names only in LibChart library code - In-Portal Issue Tracker

XML

Word

Printable

Details

Type: Bug Report
Status: Resolved
Priority: Minor
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 5.2.2-B3
Component/s: PHP Compatibility
Labels:
None

Change Log Group:
Fixed
Change Log Message:
Fixed PHP notice, when attempting to generate chart in In-Commerce.
Story Points:
1
Copy Issue Key:
Patch Instructions:
Patches must be submitted through Phabricator.
- To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial
- To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial

Description

In the "core/units/general/libchart" folder replace all usages of PHP4-style constructors (method name matches class name) with "__construct" to avoid this warnings on PHP 7+:

Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; foo has a deprecated constructor in example.php on line 3

http://php.net/manual/en/migration70.deprecated.php

Attachments

Issue Links

implemented in

[Diffusion] rINP16666 Fixes INP-1751 - Use PHP5-style constructor names only in LibChart library code

D350 INP-1751 - Use PHP5-style constructor names only in LibChart library code

Activity

People

Assignee:

Alex

Reporter:

Alex

Developer:

Alex

Reviewer:

Erik Snarski [Intechnic]

Votes:

0 Vote for this issue

Watchers:

2 Start watching this issue

Dates

Created:

29/Oct/18 8:27 AM

Updated:

1 hour ago

Resolved:

11/Jan/21 3:01 AM

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

0.75h