Protect against racing condition during Scheduled Tasks execution

Components

Labels

None

Description

In the "\kScheduledTaskManager::runAll" method, when iterating over "$events_source" array and after site domain limitation was checked:

query "LastRunOn" column value of current scheduled task from database
if it doesn't match "$event_data['LastRunOn']" (means parallel process already executed it and update the date), then continue to next scheduled task

Context Information

None

Additional information (do not use)

None

Activity

Alex January 11, 2021 at 10:57 AM

alex closed D358: - Protect against racing condition during Scheduled Tasks execution.
alex updated the diff for D358: - Protect against racing condition during Scheduled Tasks execution.

Alex January 11, 2021 at 8:57 AM

alex committed rINP16665: Fixes - Protect against racing condition during Scheduled Tasks….

Fixes - Protect against racing condition during Scheduled Tasks execution

Differential Revision: http://qa.in-portal.org/D358

Alex January 11, 2021 at 8:57 AM

alex added "INP-1753" JIRA issue(s) to rINP16665: Fixes - Protect against racing condition during Scheduled Tasks….

Alex January 11, 2021 at 8:57 AM

alex closed D358: - Protect against racing condition during Scheduled Tasks execution.
alex updated the diff for D358: - Protect against racing condition during Scheduled Tasks execution.

[API] Administrator January 11, 2021 at 8:57 AM

User committed a fix to 5.2.x. Commit Message:

Fixes - Protect against racing condition during Scheduled Tasks execution

Differential Revision: http://qa.in-portal.org/D358

Fixed

Details
Priority
Minor
Assignee
Alex
Reporter
Alex
Developer
Alex
Reviewer
Erik S.
Change Log Group
Fixed
Change Log Message
Fixed case, when scheduled task might have executed more times, then expected by it's run schedule.
Patch Instructions
Patches must be submitted through Phabricator.
To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial.
To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial.
Time tracking
1h 30m logged
Story Points
1
Original estimate
1h
Fix versions
5.2.2-B3

Created November 6, 2018 at 10:40 AM

Updated December 29, 2024 at 8:49 PM

Resolved January 11, 2021 at 8:57 AM