[INP-1773] Use "round" function during image resize instead of "ceil" - In-Portal Issue Tracker

XML

Word

Printable

Change Log Group:
Fixed
Change Log Message:
Resized images were 1px larger, than expected.
Story Points:
1
Copy Issue Key:
Patch Instructions:
Patches must be submitted through Phabricator.
- To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial
- To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial

In the "\ImageHelper::GetImageDimensions" method instead of doing "ceil(...);" in the code below do "(int)round(...);".

$width = ceil($orig_width * $ratio);
$height = ceil($orig_height * $ratio);

blocks

INP-1772 Don't use "/tmp" folder, when resizing uploaded images

implemented in

[Diffusion] rINP16651 Fixes INP-1773 - Use "round" function during image resize instead of "ceil"

D370 INP-1773 Use "round" function during image resize instead of "ceil"

Estimated:

Not Specified

Remaining:

Logged:

0.3h