Respect sub-item status, when performing unique validation

Components

Labels

None

Description

In the "kValidator::ValidateUnique" method must be changed to exclude from validation check SQL request scope records with subitem ids, that are deleted from temp table for all main items being edited currently.

Context Information

None

Additional information (do not use)

None

Activity

[API] Administrator November 13, 2023 at 8:36 AM

User @Alex committed a fix to 5.2.x. Commit Message:

Fixes - Respect sub-item status, when performing unique validation

Differential Revision: http://qa.in-portal.org/D379

Erik S. March 26, 2020 at 11:12 AM

erik accepted D379: - Respect sub-item status, when performing unique validation.
D379: - Respect sub-item status, when performing unique validation is now accepted and ready to land.

Alex March 18, 2020 at 11:45 AM

alex updated the diff for D379: - Respect sub-item status, when performing unique validation.
D379: - Respect sub-item status, when performing unique validation is now accepted and ready to land.
alex added a comment to D379: - Respect sub-item status, when performing unique validation.

Don't perform unique validation from TEMP to LIVE table, when parent record isn't yet created in TEMP table.

Alex March 18, 2020 at 9:52 AM

alex requested review of D379: - Respect sub-item status, when performing unique validation.
alex added a comment to D379: - Respect sub-item status, when performing unique validation.

Please test again. Also update test plan to include testing of added code fragment: http://qa.in-portal.org/D379?vs=927&id=929#toc .

Alex March 18, 2020 at 9:45 AM

Don't perform unique validation from TEMP to LIVE table, when parent record isn't yet created in TEMP table.

Fixed

Details
Priority
Minor
Assignee
Alex
Reporter
Alex
Developer
Alex
Reviewer
Erik S.
Change Log Group
Fixed
Change Log Message
Attempt create re-create sub-item record with a unique field was always failing.
Patch Instructions
Patches must be submitted through Phabricator.
To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial.
To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial.
Time tracking
3h 47m logged1m remaining
Story Points
2
Fix versions
5.2.2-B3

Created February 19, 2020 at 5:03 PM

Updated December 29, 2024 at 8:48 PM

Resolved November 13, 2023 at 8:36 AM