Remove duplicate primary theme detection query

Components

Labels

None

Description

In the "\kThemesHelper::getCurrentThemeId" method instead of performing primary+enabled theme quering SQL call "\kApplication::GetDefaultThemeId" with "true" argument.

Context Information

None

Additional information (do not use)

None

Activity

[API] Administrator July 8, 2022 at 1:55 PM

User committed a fix to 5.2.x. Commit Message:

Fixes - Remove duplicate primary theme detection query

Differential Revision: http://qa.in-portal.org/D400

Erik S. March 17, 2021 at 10:38 AM

erik accepted D400: - Remove duplicate primary theme detection query.
D400: - Remove duplicate primary theme detection query is now accepted and ready to land.
erik added a comment to D400: - Remove duplicate primary theme detection query.

Tested. Parent Section dropdown is not empty, "Home" value is visible in the Parent Section dropdown.

Alex March 15, 2021 at 10:47 AM

alex requested review of D400: - Remove duplicate primary theme detection query.

Fixed

Details
Priority
Minor
Assignee
Alex
Reporter
Alex
Developer
Alex
Reviewer
Erik S.
Change Log Group
Fixed
Change Log Message
Removed duplicate database query for detecting primary theme.
Patch Instructions
Patches must be submitted through Phabricator.
To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial.
To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial.
Time tracking
40m logged
Story Points
1
Fix versions
5.2.2-B3

Created March 15, 2021 at 10:38 AM

Updated December 29, 2024 at 8:49 PM

Resolved July 8, 2022 at 1:55 PM