Properly dispose session during logout workflow

Components

Labels

None

Description

Add "$this->SessionSet = false;" code in the "\InpSession::Destroy" method.

Context Information

The "SessionSet" flag is reset in "\Session::Destroy" method, but not in "\InpSession::Destroy" method. Because of this any code, that calls "\kApplication::RemoveVar" method in hooks to the "adm:OnBeforeShutdown" would result in session data removal SQL being executed without SessionKey in it.

The above-mentioned “Destroy” method is called during session expiration and user logout flows.

Additional information (do not use)

None

Activity

[API] Administrator July 29, 2024 at 2:57 PM

User committed a fix to 5.2.x. Commit Message:

Fixes - Properly dispose session during logout workflow

Differential Revision: http://qa.in-portal.org/D477

Fixed

Details
Priority
Minor
Assignee
Alex
Reporter
Alex
Developer
Alex
Reviewer
Erik S.
Change Log Group
Fixed
Change Log Message
Fixed potential SQL error during user logout flow.
Patch Instructions
Patches must be submitted through Phabricator.
To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial.
To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial.
Time tracking
1h 18m logged
Story Points
1
Fix versions
5.2.2-B3

Created July 29, 2024 at 1:03 PM

Updated December 29, 2024 at 8:47 PM

Resolved July 29, 2024 at 2:57 PM