-
Type: Bug Report
-
Status: Closed
-
Priority: Minor
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 5.2.2-B1
-
Component/s: Optimization
-
Labels:
-
External issue URL:
-
Additional information:
-
Change Log Group:Changed
-
Change Log Message:Massive code cleanup.
-
Story Points:3
-
External issue ID:268
-
Copy Issue Key:
-
Patch Instructions:
-
BC Break Details:
This an ongoing task for Code cleanup in the whole system in 5.2.x branch.
---------------
1. kModRewriteHelper and kUrlManager both works with urls and get some data from kApplication class too. Need to unify url build/parse process (maybe by creating kiUrlProcessor interface, that will be implemented in PlainUrlProcessor and RewriteUrlProcessor classes).
2. Temp Handler class optimization:
- implement class using Collection pattern (like tests are collected in phpUnit) and create Clone, Delete, etc. methods for the class.
- this way operations will be single-item based, not table-based as right now.
- This of course will result separate sqls for subitem quering based on individual parent, but that's small price to pay to have correctly organized class hierarchy
3. INP-999 - Email event usage refactoring (part 1)
- create kEmail class with following public methods:
- findEvent($name, $type)
- setParams($params)
- send()
- make $this->sender refer to kEmailSendingHelper class instance for easy access across all methods
- move existing code from EmailEventsEventHandler into new kEmail class
- replace OnEmailEvent event sending with new kEmail class usage
4. Email event refactoring (part 2)
- replace tons of "switch by RecipientType (to, cc, bcc) field" into polymorphism
- parent of
-
INP-1025 Put default theme/language in URL cache, when none specified in url
- Closed
-
INP-1145 Retain user scroll position, when re-opening Debugger report
- Closed
- relates to
-
INP-386 Migration to PHP5 (ongoing)
- Closed
-
INP-999 Email event usage refactoring
- Closed
-
INP-811 Add "System Log" section for recording all notices/warnings/errors
- Closed
-
INP-937 Minimizing In-Portal CORE
- New
- mentioned in
-
Page Loading...
-
Page Loading...
-
Wiki Page Loading...
-
Wiki Page Loading...
-
Wiki Page Loading...