Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Automatic CSS / JS Compression

Components

Labels

Description

The elegant and simple implementation (doesn't exist yet) of solving problems with large javascript, css files being sent on every page load.

Instead of
<script type="text/javascript"
src="<inp2:m_TemplatesBase/>js/script.js"></script>

we should use

<script type="text/javascript" src="<inp2:m_Script
file="js/script.js"/>"></script>

Tag Script would:

1. get compressed version of given file based on current theme (compressed
versions could be stored under "/system/cache")

2. if given file was changed after compressed file was created, then create
compressed file with file modification time in it's name and return url to
compressed file

3. if given file wasn't changed after compressed file was created, then
return url to compressed file

There would not be any additional calls to index.php to load every
compressed javascript, because of tag implementation is being used. What
ever compression is made or not could be determined by new configuration
variable. Compression could be turned off automatically, when debug mode is
turned on for example. What compressor to use would be determined based on
given file extension. What compressor engine to use will be determined in
later development stages of this feature (command-line, php, java etc.).

[B]NOTE:/B

We should be able to process multiple JS files (and probably CSS) in a single minimized version.

Let's say I want something like this <script type="text/javascript"
src="<inp2:m_Script file="js/script.js|js/another_jq.js"/>"></script>
I did see it a few times like this - can't remember the software /
website, but will find this and put examples here.

Steps to Reproduce:

Need to find good Compress methods for both CSS and JS files.

Here are some samples:

Context Information

None

Additional information (do not use)

None

Attachments

6
  • 18 May 2010, 01:02 PM
  • 15 May 2010, 12:36 PM
  • 12 May 2010, 09:38 AM
  • 04 May 2010, 07:06 PM
  • 04 May 2010, 07:05 PM
  • 04 May 2010, 07:05 PM

Activity

Alex July 22, 2010 at 8:06 PM

Closing, since 5.1.0 release has been released.

Dmitry Andrejev May 31, 2010 at 7:52 PM

Reopened by mistaken.

Dmitry Andrejev May 31, 2010 at 7:52 PM

Completed.

Alex May 31, 2010 at 9:56 AM

There is no problem with compression at all. Since now all JS is merged into one file, then you will see errors from all js files on every page, even if it's not used there.

In this case, problem was in "form_controls.js" file with trailing comma in object declaration. Problem was moved here #0000757. Please test this task and I will make it resolved.

Dmitry Andrejev May 31, 2010 at 12:37 AM

UPDATE:

There are some JS errors when compression is ON or OFF in IE 8 with compatibility mode On or IE7. All details posted here.

Below are the error list provided by IE (I am trying to go to Polls grid after login)

=============
Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; GTB6.4; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; InfoPath.2)
Timestamp: Mon, 31 May 2010 00:25:55 UTC

Message: Expected identifier, string or number
Line: 1079
Char: 235
Code: 0
URI: http://www.jurmala.com/SVN/5.1.x/system/cache/c_1159502181_1275265484.js

Message: 'TB' is undefined
Line: 31
Char: 1
Code: 0
URI: http://www.jurmala.com/SVN/5.1.x/admin/index.php?env=-tree:m0--1--s-

Message: Object expected
Line: 13
Char: 2
Code: 0
URI: http://www.jurmala.com/SVN/5.1.x/core/admin_templates/js/tree.js

Message: Object expected
Line: 301
Char: 2
Code: 0
URI: http://www.jurmala.com/SVN/5.1.x/core/admin_templates/js/tree.js

Message: 'Application' is undefined
Line: 359
Char: 3
Code: 0
URI: http://www.jurmala.com/SVN/5.1.x/admin/index.php?env=-tree:m0--1--s-

Message: Expected identifier, string or number
Line: 1079
Char: 235
Code: 0
URI: http://www.jurmala.com/SVN/5.1.x/system/cache/c_1159502181_1275265484.js

Message: Expected identifier, string or number
Line: 1079
Char: 235
Code: 0
URI: http://www.jurmala.com/SVN/5.1.x/system/cache/c_1159502181_1275265484.js

Message: 'TB' is undefined
Line: 30
Char: 1
Code: 0
URI: http://www.jurmala.com/SVN/5.1.x/admin/index.php?env=-in-bulletin/polls/poll_list:m0--1--s-

Message: 'TB' is undefined
Line: 31
Char: 1
Code: 0
URI: http://www.jurmala.com/SVN/5.1.x/admin/index.php?env=-head:m0--1--s-

Message: Object expected
Line: 217
Char: 3
Code: 0
URI: http://www.jurmala.com/SVN/5.1.x/admin/index.php?env=-in-bulletin/polls/poll_list:m0--1--s-

Message: 'AjaxPopupManager' is undefined
Line: 188
Char: 2
Code: 0
URI: http://www.jurmala.com/SVN/5.1.x/admin/index.php?env=-head:m0--1--s-

Message: 'ToolBar' is undefined
Line: 233
Char: 7
Code: 0
URI: http://www.jurmala.com/SVN/5.1.x/admin/index.php?env=-in-bulletin/polls/poll_list:m0--1--s-

Message: 'Application' is undefined
Line: 286
Char: 3
Code: 0
URI: http://www.jurmala.com/SVN/5.1.x/admin/index.php?env=-head:m0--1--s-

Message: 'ToolBar' is undefined
Line: 305
Char: 8
Code: 0
URI: http://www.jurmala.com/SVN/5.1.x/admin/index.php?env=-in-bulletin/polls/poll_list:m0--1--s-

Message: 'GridScrollers' is undefined
Line: 362
Char: 3
Code: 0
URI: http://www.jurmala.com/SVN/5.1.x/admin/index.php?env=-in-bulletin/polls/poll_list:m0--1--s-

Message: 'Grids' is undefined
Line: 525
Char: 2
Code: 0
URI: http://www.jurmala.com/SVN/5.1.x/admin/index.php?env=-in-bulletin/polls/poll_list:m0--1--s-

Message: 'Application' is undefined
Line: 548
Char: 3
Code: 0
URI: http://www.jurmala.com/SVN/5.1.x/admin/index.php?env=-in-bulletin/polls/poll_list:m0--1--s-
===============

Fixed

Details

Priority

Assignee

Reporter

Developer

Change Log Message

Patch Instructions

Patches must be submitted through Phabricator.

External issue ID

External issue URL

http://tracker.in-portal.org/view.php?id=457

Fix versions

Affects versions

Created December 16, 2009 at 8:45 PM
Updated December 30, 2024 at 2:27 AM
Resolved July 22, 2010 at 8:06 PM