Usability improvement to kCurlHelper class

Components

Labels

Description

In-Portal has kCurlHelper class to automate process of retrieving data from other API's or websites, like Google Data API or RSS feeds.

All works fine, when queried website has no errors. In case if website sends 500 HTTP response code (error) or there will be a connection timeout to that site, then response from kCurlHelper::Send method will be the same: empty string.

Such result is not sufficient for web sites, where empty string means something special response. In such cases I usually check for last HTTP code to be 200 OK and no connection error has occurred.

In attached patch there is new kCurlHelper::isGoodResponce method for doing all that.

Context Information

None

Additional information (do not use)

None

Attachments

1

Activity

Show:

Alex September 19, 2011 at 9:08 PM

Closing, since 5.1.3 release has been released.

Alex September 16, 2011 at 2:07 PM

Fix committed to [b]5.1.x branch/b. Commit Message:

Fixes #0000991: Usability improvement to kCurlHelper class

Dmitry Andrejev September 12, 2011 at 3:15 AM

Moved to 5.1.3 release since small, but useful to have.

Dmitry Andrejev February 5, 2011 at 9:55 PM

Patch tested good.

Fixed

Priority

Assignee

Alex

Reporter

Developer

Change Log Message

Patch Instructions

Patches must be submitted through Phabricator.

External issue ID

Fix versions

Affects versions

Created February 5, 2011 at 2:12 PM
Updated December 29, 2024 at 9:12 PM
Resolved September 19, 2011 at 9:08 PM