Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fields

Components

Labels

None

Description

In the "\OrdersItem::SetFieldsFromHash" method instead of using "kDBItem::GetDirtyField" method directly check presence of "PaymentCCExpMonth" and "PaymentCCExpYear" keys in the "$hash" array.

Context Information

None

Additional information (do not use)

None

Activity

[API] Administrator July 8, 2022 at 8:20 AM

User @Alex committed a fix to 5.2.x. Commit Message:

Fixes https://in-portal.atlassian.net/browse/MINC-196#icft=MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fields

Differential Revision: http://qa.in-portal.org/D395

Erik S. February 23, 2021 at 10:56 AM

erik accepted D395: https://in-portal.atlassian.net/browse/MINC-196#icft=MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fields.
D395: https://in-portal.atlassian.net/browse/MINC-196#icft=MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fields is now accepted and ready to land.

Alex February 23, 2021 at 9:28 AM

alex updated the diff for D395: https://in-portal.atlassian.net/browse/MINC-196#icft=MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fields.
alex added a comment to D395: https://in-portal.atlassian.net/browse/MINC-196#icft=MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fields.

Previous fix changed logic of the code to allow empty field values, but that wasn't on purpose.

Alex February 23, 2021 at 9:19 AM

alex added a project to D395: https://in-portal.atlassian.net/browse/MINC-196#icft=MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fields: Intechnic: RPI.

Alex February 23, 2021 at 9:19 AM

alex requested review of D395: https://in-portal.atlassian.net/browse/MINC-196#icft=MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fields.

Fixed

Details
Priority
Minor
Assignee
Alex
Reporter
Alex
Developer
Alex
Reviewer
Erik S.
Change Log Group
Fixed
Change Log Message
Fixed notices upon sale order saving.
Patch Instructions
Patches must be submitted through Phabricator.
To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial.
To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial.
Time tracking
30m logged
Story Points
1
Fix versions
5.2.2-B3

Created February 23, 2021 at 9:11 AM

Updated December 29, 2024 at 11:25 PM

Resolved July 8, 2022 at 8:20 AM