Uploaded image for project: 'In-Portal CMS'
  1. In-Portal CMS
  2. INP-1177

Use "E-mail Templates" term in codebase instead of "E-mail Events"

    XMLWordPrintable

    Details

    • Change Log Group:
      Changed
    • Change Log Message:
      Renamed "e-mail events" into "e-mail templates". Renamed "kApplication::EmailEventAdmin" into "kApplication::emailAdmin". Renamed "kApplication::EmailEventUser" into "kApplication::emailUser".
    • Story Points:
      1
    • External issue ID:
      1424
    • Copy Issue Key:
    • Patch Instructions:

      Patches must be submitted through Phabricator.

    • BC Break Details:
      Hide

      Renamed units:

      • "emailevents" into "email-template"

      Renamed classes:

      • "EmailEventsEventsHandler" into "EmailTemplateEventHandler"
      • "EmailEventTagProcessor" into "EmailTemplateTagProcessor"
      • "kEmailMessageHelper" into "kEmailTemplateHelper"

      Renamed methods:

      • "PhraseTagProcessor::EventCount" into "PhraseTagProcessor::TemplateCount"
      Show
      Renamed units: "emailevents" into "email-template" Renamed classes: "EmailEventsEventsHandler" into "EmailTemplateEventHandler" "EmailEventTagProcessor" into "EmailTemplateTagProcessor" "kEmailMessageHelper" into "kEmailTemplateHelper" Renamed methods: "PhraseTagProcessor::EventCount" into "PhraseTagProcessor::TemplateCount"

      Description

      1. In-Portal has "E-mail Templates" section, where all e-mail templates are defined.
      Later via special function call developer can render each of templates and send result to e-mail address given.

      But internally we call them as "e-mail events". I think we should do some renaming to have "e-mail templates" term across the system.

      2. We also validate, during e-mail sending, that supplied e-mail event name has only upper case letters and dots, but we don't validate the same upon e-mail event adding/editing.

      This way it's possible to enter e-mail event name, that won't be sent just because it's named incorrectly.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                alex Alex
                Reporter:
                alex Alex
                Developer:
                Alex
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: