Uploaded image for project: 'In-Portal CMS'
  1. In-Portal CMS
  2. INP-571

Prev/Next buttons are always enabled

    XMLWordPrintable

    Details

    • Type: Bug Report
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.0.3-RC1
    • Fix Version/s: 5.0.3
    • Component/s: Admin Interfaces
    • Labels:
      None
    • External issue URL:
    • Additional information:
      Hide

      This is button code sample:
      <inp2:m_if check="poll_IsSingle">
      a_toolbar.HideButton('prev');
      a_toolbar.HideButton('next');
      a_toolbar.HideButton('sep1');
      <inp2:m_else/>
      <inp2:m_if check="poll_IsLast">
      a_toolbar.DisableButton('next');
      </inp2:m_if>
      <inp2:m_if check="poll_IsFirst">
      a_toolbar.DisableButton('prev');
      </inp2:m_if>
      </inp2:m_if>

      Show
      This is button code sample: <inp2:m_if check="poll_IsSingle"> a_toolbar.HideButton('prev'); a_toolbar.HideButton('next'); a_toolbar.HideButton('sep1'); <inp2:m_else/> <inp2:m_if check="poll_IsLast"> a_toolbar.DisableButton('next'); </inp2:m_if> <inp2:m_if check="poll_IsFirst"> a_toolbar.DisableButton('prev'); </inp2:m_if> </inp2:m_if>
    • External issue ID:
      721
    • Copy Issue Key:
    • Patch Instructions:

      Patches must be submitted through Phabricator.

      Description

      On 5.0.3-B2 release Prev/Next buttons are always enabled, even, when there is not prev. button available.

      How to reproduce:

      • select 2 sections in structure & data
      • click edit button
      • now you see 1st selected section -> click next
      • now you see 2nd selected section -> click next
      • now you see broken page without any section

      This is all because of fix, that disabled toolbar buttons until page is fully loaded and then enabled them.

      There are two ways to fix this:

      1. call prev/next buttton js via $(document).ready event
      2. don't disable toolbar buttons until page is fully loaded, but just make them readonly (new state, that will act like disabled, but button won't be grayed out)

      That new "ReadOnly" status will be for internal use only.

        Attachments

          Issue Links

          relates to

          Bug Report - A problem which impairs or prevents the functions of the product. INP-469 Quick "Modal Window" opening leads to js error

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          mentioned in

          Page Loading...

          Page Loading...

            Activity

              People

              • Assignee:
                alex Alex
                Reporter:
                alex Alex
                Developer:
                Alex
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: