[INP-826] Phrase type detection based on it's name - In-Portal Issue Tracker

XML

Word

Printable

External issue URL:
http://tracker.in-portal.org/view.php?id=1024
Additional information:

Hide

Plan:

1. add new "lc_" phrase label prefix (to phrase name validate regex);
2. remove "Phrase Type" field from phrase form;
3. set phrase type automatically based on phrase label prefix;
4. change prefix (and type) for phrases, that can be used in both places (e.g. field option phrases for sure).
5. create fixed language pack + upgrade script that will rename Phrase & PhraseKey columns during an upgrade.

Show
Plan: 1. add new "lc_" phrase label prefix (to phrase name validate regex); 2. remove "Phrase Type" field from phrase form; 3. set phrase type automatically based on phrase label prefix; 4. change prefix (and type) for phrases, that can be used in both places (e.g. field option phrases for sure). 5. create fixed language pack + upgrade script that will rename Phrase & PhraseKey columns during an upgrade.
Change Log Message:
Simplified phrase adding screen
Story Points:
2
External issue ID:
1024
Copy Issue Key:
Patch Instructions:
Patches must be submitted through Phabricator.
- To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial
- To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial

On phrase adding screen you need to enter:

However phrase type can be automatically guessed based on phrase label prefix:

parent of

INP-1247 Allow using "lc_*" phrases in "Phrases::ReplaceLanguageTags" method

relates to

INP-410 Redirect template (kEvent::redirect attribute) has no effect, when popups are used

INP-894 Optimizing storage of help phrases